Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes-sigs/controller-tools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.12.0
Choose a base ref
...
head repository: kubernetes-sigs/controller-tools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.12.1
Choose a head ref
  • 5 commits
  • 7 files changed
  • 3 contributors

Commits on Jul 13, 2023

  1. Add a testcase to reproduce bug of markers 

    Markers might be lost in generated CRD when the package containing
markers is referenced by several packages and CRD is generated by
those packages.

For more details, see #783.
    @ntoofu
    ntoofu authored and k8s-infra-cherrypick-robot committed Jul 13, 2023
    Copy the full SHA
    ce59fd8 View commit details

  2. Update marker.Collector to fix bug of markers 

    Markers are saved per `*ast.TypeSpec`, which is specific to `Package` object.
`*ast.TypeSpec` in another `Package` object is different even when
the `Package.ID` is the same, and so collected markers cannot be reused
for another `Package` object.

Therefore, `Package` itself is used as a key for cache of markers
insetead of `Package.ID`.

For more details about the bug, see #783.
    @ntoofu
    ntoofu authored and k8s-infra-cherrypick-robot committed Jul 13, 2023
    Copy the full SHA
    c4c89f7 View commit details

  3. Return an error for duplicate generators 

    Return an error from controller-gen if the command includes multiple
instances of the same generator.
    @rainest
    rainest authored and k8s-infra-cherrypick-robot committed Jul 13, 2023
    Copy the full SHA
    35f6df7 View commit details

  4. Merge pull request #834 from k8s-infra-cherrypick-robot/cherry-pick-7… 

    …92-to-release-0.12

[release-0.12] 🐛 Change the type of `markers.Collector.byPackage`'s key from `string` to `*loader.Package`
    @k8s-ci-robot
    k8s-ci-robot authored Jul 13, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    3c09a34 View commit details

  5. Merge pull request #835 from k8s-infra-cherrypick-robot/cherry-pick-8… 

    …29-to-release-0.12

[release-0.12] ✨ Return an error for duplicate generators
    @k8s-ci-robot
    k8s-ci-robot authored Jul 13, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    371c48c View commit details
Loading