Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delayed job unexpected cancellation #962

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Feb 3, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #958

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix delayed job unexpected cancellation

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Feb 3, 2024
Copy link

netlify bot commented Feb 3, 2024

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 3ca530f
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/65be227690ef9400084ee6e1

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 3, 2024
@wzshiming
Copy link
Member Author

/cherrypick release-0.5

@k8s-infra-cherrypick-robot

@wzshiming: once the present PR merges, I will cherry-pick it on top of release-0.5 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wzshiming wzshiming changed the title Fix delayed job unexpected cancellation [WIP] Fix delayed job unexpected cancellation Feb 3, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2024
@wzshiming wzshiming changed the title [WIP] Fix delayed job unexpected cancellation Fix delayed job unexpected cancellation Feb 6, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2024
@wzshiming wzshiming merged commit 6e3835b into kubernetes-sigs:main Feb 6, 2024
30 of 31 checks passed
@wzshiming wzshiming deleted the fix/delay-job branch February 6, 2024 07:41
@k8s-infra-cherrypick-robot

@wzshiming: new pull request created: #965

In response to this:

/cherrypick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delayed stages sometimes not executed
3 participants