Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update golangci-lint and logtools to fix verify fail #1198

Merged
merged 1 commit into from
Feb 26, 2023
Merged

update golangci-lint and logtools to fix verify fail #1198

merged 1 commit into from
Feb 26, 2023

Conversation

yangjunmyfm192085
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 commented Feb 22, 2023 •
edited
Loading

What this PR does / why we need it:
update golangci-lint and logtools to fix verify fail
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 22, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 22, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If metrics-server contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 22, 2023
@yangjunmyfm192085
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2023
@yangjunmyfm192085 yangjunmyfm192085 marked this pull request as draft February 22, 2023 11:17
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2023
@yangjunmyfm192085
Copy link
Contributor Author

/test pull-metrics-server-verify

@yangjunmyfm192085
Copy link
Contributor Author

/test pull-metrics-server-verif

@k8s-ci-robot
Copy link
Contributor

@yangjunmyfm192085: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-metrics-server-test-e2e
  • /test pull-metrics-server-test-e2e-ha
  • /test pull-metrics-server-test-e2e-helm
  • /test pull-metrics-server-test-unit
  • /test pull-metrics-server-test-version
  • /test pull-metrics-server-verify

Use /test all to run all jobs.

In response to this:

/test pull-metrics-server-verif

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yangjunmyfm192085
Copy link
Contributor Author

/test pull-metrics-server-verify

@yangjunmyfm192085
Copy link
Contributor Author

/test pull-metrics-server-verify

@yangjunmyfm192085 yangjunmyfm192085 marked this pull request as ready for review February 24, 2023 07:46
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2023
@yangjunmyfm192085 yangjunmyfm192085 changed the title update logtools to fix verify fail update golangci-lint and logtools to fix verify fail Feb 24, 2023
yangjunmyfm192085
yangjunmyfm192085 commented Feb 24, 2023
View reviewed changes
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2023
@yangjunmyfm192085
Copy link
Contributor Author

/cc @serathius @dgrisonnet

@serathius
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius, yangjunmyfm192085

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6e0bdd1 into kubernetes-sigs:master Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@serathius serathius Awaiting requested review from serathius

Assignees

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yangjunmyfm192085 @k8s-ci-robot @serathius