Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(chart): Defined chart release v3.9.0 #1227

Merged
merged 1 commit into from
Mar 28, 2023
Merged

chore(chart): Defined chart release v3.9.0 #1227

merged 1 commit into from
Mar 28, 2023

Conversation

stevehipwell
Copy link
Contributor

What this PR does / why we need it:
This PR makes the chart change on master to be cherry picked to release-0.6 alongside the other chart change commits.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #1213

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 27, 2023
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 27, 2023
@stevehipwell
Copy link
Contributor Author

/triage accepted
/assign @dgrisonnet

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 27, 2023
@stevehipwell stevehipwell mentioned this pull request Mar 27, 2023
Closed
@stevehipwell
Copy link
Contributor Author

/retest

1 similar comment
@stevehipwell
Copy link
Contributor Author

/retest

yangjunmyfm192085
yangjunmyfm192085 approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/cc @dgrisonnet

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevehipwell, yangjunmyfm192085

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stevehipwell
Copy link
Contributor Author

@yangjunmyfm192085 could you LGTM with the slash command?

@yangjunmyfm192085
Copy link
Contributor

sure
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 48cc4e6 into kubernetes-sigs:master Mar 28, 2023
@stevehipwell stevehipwell deleted the helm-chart-v3.9.0 branch March 28, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangjunmyfm192085 yangjunmyfm192085 yangjunmyfm192085 approved these changes

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

Assignees

@dgrisonnet dgrisonnet

@yangjunmyfm192085 yangjunmyfm192085

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevehipwell @k8s-ci-robot @yangjunmyfm192085 @dgrisonnet