Fixed External IPs service link. #7317
Conversation
| @@ -11,4 +11,4 @@ name: cluster-autoscaler | |||
| sources: | |||
| - https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler | |||
| type: application | |||
| version: 9.43.0 | |||
| version: 9.43.1 | |||
There was a problem hiding this comment.
I don't think updating docs via helm-docs would satisfy the need to cut a new patch version, so let's skip this?
There was a problem hiding this comment.
@jackfrancis, if we don't update the helm chart version then Lint and Test Charts / Helm chart (pull_request) will fail.
because we use automated tooling to build and publish the releases of the helm chart, here is the workflow link:
https://github.com/kubernetes/autoscaler/blob/master/.github/workflows/release.yaml#L4-L29
There was a problem hiding this comment.
Thanks @jackfrancis
|
/lgtm to @gjtempleton for approval |
|
Hi @gjtempleton Thanks! |
|
Thanks |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjtempleton, Shubham82 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixed the External IPs link under the CA Chart README.md.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: