Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HPA tolerance to be a flag #18155

Closed
jayunit100 opened this issue Dec 3, 2015 · 5 comments · Fixed by #52275
Closed

Update HPA tolerance to be a flag #18155

jayunit100 opened this issue Dec 3, 2015 · 5 comments · Fixed by #52275
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling.

Comments

@jayunit100
Copy link
Member

We'd like tolerance to be settable to a low value (for e2es) and of course a high value for some clusters which don't want too much unnecessary jitter. I'll update with a PR shortly... This can be an isolated fix.
@jayunit100
Copy link
Member Author

cc @timothysc @piosz part of the #18097

@piosz
Copy link
Member

piosz commented Dec 3, 2015

cc @jszczepkowski

@jszczepkowski jszczepkowski added the sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. label Dec 3, 2015
@pmorie
Copy link
Member

pmorie commented Dec 3, 2015

@DirectXMan12 @kubernetes/rh-cluster-infra

@jayunit100 jayunit100 mentioned this issue Dec 4, 2015
Closed
@jszczepkowski jszczepkowski mentioned this issue Dec 14, 2015
Closed
@ikehz
Copy link
Contributor

ikehz commented Dec 22, 2015

As far as I understand, this isn't something the test-infra team needs to be working on. Please correct me if I'm wrong, but I'll remove the label until then.

@davidopp davidopp added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Jan 24, 2016
@mattjmcnaughton
Copy link
Contributor

Is this still a feature of interest? I see the TODO: still exists. If so - I'd love to take a stab. I've been looking for a starter project for the auto-scaling code base, and it seems like this could be a good fit.

@mattjmcnaughton mattjmcnaughton mentioned this issue Sep 11, 2017
Merged
mattjmcnaughton added a commit to mattjmcnaughton/kubernetes that referenced this issue Sep 12, 2017
@mattjmcnaughton
Make HPA tolerance a flag
1cf1e0c 
Fix kubernetes#18155

Make HPA tolerance configurable as a flag. This change allows us to use
different tolerance values in production/testing.

Signed-off-by: mattjmcnaughton <[email protected]>
mattjmcnaughton added a commit to mattjmcnaughton/kubernetes that referenced this issue Sep 13, 2017
@mattjmcnaughton
Make HPA tolerance a flag
cfb8c0a 
Fix kubernetes#18155

Make HPA tolerance configurable as a flag. This change allows us to use
different tolerance values in production/testing.

Signed-off-by: mattjmcnaughton <[email protected]>
mattjmcnaughton added a commit to mattjmcnaughton/kubernetes that referenced this issue Sep 14, 2017
@mattjmcnaughton
Make HPA tolerance a flag
d7a29f0 
Fix kubernetes#18155

Make HPA tolerance configurable as a flag. This change allows us to use
different tolerance values in production/testing.

Signed-off-by: mattjmcnaughton <[email protected]>
mattjmcnaughton added a commit to mattjmcnaughton/kubernetes that referenced this issue Sep 29, 2017
@mattjmcnaughton
Make HPA tolerance a flag
abd4668 
Fix kubernetes#18155

Make HPA tolerance configurable as a flag. This change allows us to use
different tolerance values in production/testing.

Signed-off-by: mattjmcnaughton <[email protected]>
k8s-github-robot pushed a commit that referenced this issue Oct 16, 2017
Merge pull request #52275 from mattjmcnaughton/mattjmcnaughton/18155-…
03cb11f 
…hpa-tolerance-should-be-flag

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Make HPA tolerance a flag

**What this PR does / why we need it**:
Make HPA tolerance configurable as a flag. This change allows us to use
different tolerance values in production/testing.

**Which issue this PR fixes**: 
Fixes #18155

**Release note:**
```release-note
Control HPA tolerance through the `horizontal-pod-autoscaler-tolerance` flag.
```

Signed-off-by: mattjmcnaughton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make HPA tolerance a flag mattjmcnaughton/kubernetes
9 participants
@pmorie @ikehz @jayunit100 @mattjmcnaughton @davidopp @saad-ali @piosz @jszczepkowski @bgrant0607-nocc