Made image as deliberately optional in v1 Container struct.

[gyliu513]

What this PR does / why we need it:
Revert #47246
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

Mark image as deliberately optional in v1 Container struct.  Many objects in the Kubernetes API inherit the container struct and only Pods require the field to be set.

[gyliu513]

/cc @bgrant0607 @smarterclayton

[gyliu513]

/sig api-machinery

[smarterclayton]

Hold on this, conversation in the other thread.

[smarterclayton]

Marking this a candidate, still needs discussion. Not required for feature freeze but don't want to forget it.

[bgrant0607]

@smarterclayton Which other thread? #47246? Indeed, a user there reported that this broke them, since validation runs in kubectl. I think we need to revert the change and backport it to 1.7. I'd even like to remove the validation from the controllers in v1beta2 in 1.9 and just have them not create pods if the field is empty.

[smarterclayton]

Agreed, revert and backport. Just qualifies as bug.

[smarterclayton]

Can you rebase so we can get this merged and back ported?

[smarterclayton]

/test pull-kubernetes-bazel-build

[dims]

/retest

[dims]

/test all

[dims]

@gyliu513 - Can you please see the failures and help get the tests go green? i am afraid this will miss the 1.8 otherwise.

[gyliu513]

@dims I filed an issue here #52727 reporting some errors when hack/update-all.sh, can you help check? I suspect the error may cause some files can not be generated.

[gyliu513]

/retest

[gyliu513]

/test pull-kubernetes-e2e-gce-bazel

[gyliu513]

@smarterclayton @dims

[gyliu513]

/release-note

[smarterclayton]

/lgtm

[spiffxp]

@smarterclayton this needs an /approve no-issue or @gyliu513 needs to refer to an issue (not PR) in the "fixes #" part of the PR description before the bot will add an approved label

[smarterclayton]

/approve no-issue

…

On Wed, Sep 20, 2017 at 6:49 PM, Aaron Crickenberger < ***@***.***> wrote: @smarterclayton <https://github.com/smarterclayton> this needs an /approve no-issue or @gyliu513 <https://github.com/gyliu513> needs to refer to an issue (not PR) in the "fixes #" part of the PR description before the bot will add an approved label — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#48406 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_p6OmLeXjEAcHjKKuIaw8TEjzcwTPks5skZaPgaJpZM4OLwUe> .

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyliu513, smarterclayton

Associated issue requirement bypassed by: smarterclayton

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• api/OWNERS [smarterclayton]
• docs/OWNERS [smarterclayton]
• federation/OWNERS [smarterclayton]
• pkg/kubectl/OWNERS [smarterclayton]
• staging/src/k8s.io/api/core/OWNERS [smarterclayton]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 48406, 52819). If you want to cherry-pick this change to another branch, please follow the instructions here..