-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing usage of clustered datastore name to be absolute datastore name #54438
Fixing usage of clustered datastore name to be absolute datastore name #54438
Conversation
Hi @pshahzeb. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/release-note-none |
/assign @abrarshivani |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrarshivani, pshahzeb Associated issue: 312 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test pull-kubernetes-unit |
@pshahzeb: you can't request testing unless you are a kubernetes member. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-kubernetes-unit |
@divyenpatel: you can't request testing unless you are a kubernetes member. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-kubernetes-unit |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
…-upstream-release-1.8 Automatic merge from submit-queue. Automated cherry pick of #54438 upstream release-1.8 Cherry pick of #54438 on release-1.8 #54438: Fixing usage of clustered datastore name to be absolute datastore name Without this Fix, Clustered Datastore or Datastore within storage folder can not be used with Release 1.8 of Kubernetes. @pshahzeb Release note: ``` Fix clustered datastore name to be absolute. ```
What this PR does / why we need it:
This PR adds the step to convert the datastore name in form of a folder/cluster to absolute datastore name.
Which issue this PR fixes: fixes vmware#312
Special notes for your reviewer:
Testing. All the clustered datastore tests pass now
Release note: