Add HA feature gate and minVersion validation #54539
Conversation
|
/test pull-kubernetes-unit |
cmd/kubeadm/app/features/features.go
Outdated
| @@ -22,22 +22,66 @@ import ( | |||
| "strconv" | |||
| "strings" | |||
|
|
|||
| utilfeature "k8s.io/apiserver/pkg/util/feature" | |||
There was a problem hiding this comment.
yeah, I asked that myself. But we're not actually using that much from it, just a few string types, so it doesn't add much value TBH. If we embedded those structs, we'd need to start doing stuff like
HighAvailability: {utilfeature.FeatureSpec{Default: false, PreRelease: alpha}, MinimumVersion: v190},
which looks a bit weird imo.
There was a problem hiding this comment.
I don't really mind either way, we can keep on using it if somebody has a strong preference
There was a problem hiding this comment.
I would like to stay close in sync as possible with upstream, please.
There was a problem hiding this comment.
Sure, I will add back those types. However I don't think there is consistent tooling around this for "upstream". Here we're just cribbing off what apiserver does.
There was a problem hiding this comment.
heh, can be generally improved indeed, yes
cmd/kubeadm/app/features/features.go
Outdated
| ) | ||
|
|
||
| var v190, _ = version.ParseSemantic("v1.9.0") |
cmd/kubeadm/app/features/features.go
Outdated
| if requestedVersion == "" { | ||
| return nil | ||
| } | ||
| parsedExpVersion, err := version.ParseGeneric(requestedVersion) |
|
/test pull-kubernetes-unit |
c121e17
to
0ff425d
Compare
|
/test pull-kubernetes-unit |
| ) | ||
|
|
||
| var v190 = version.MustParseSemantic("v1.9.0") |
There was a problem hiding this comment.
sigh that should probably be v1.9.0-alpha.1 😄
There was a problem hiding this comment.
@luxas Yep, I'll update this in a follow-up PR
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jamiehannaford, luxas Associated issue: 261 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 54593, 54607, 54539, 54105). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
As we add more feature gates, there might be occasions where a feature is only available on newer releases of K8s. If a user makes a mistake, we should notify them as soon as possible in the init procedure and not them go down the path of hard-to-debug component issues.
Specifically with HA, we ideally need the new
TaintNodesByCondition(added in v1.8.0 but working in v1.9.0).Which issue this PR fixes:
kubernetes/kubeadm#261
kubernetes/kubeadm#277
Release note:
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews @luxas @timothysc