Optionally prevent metadata concealment firewall from being set #58104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @cjcullen |
|
/retest |
|
/lgtm |
|
/assign @bowei |
|
/unassign @bowei |
|
/retest |
|
/approve no-issue |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, cjcullen, ihmccreery Associated issue requirement bypassed by: bowei The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue (batch tested with PRs 58104, 58492, 58491). If you want to cherry-pick this change to another branch, please follow the instructions here. |
This was referenced Jan 22, 2018
k8s-github-robot
pushed a commit
that referenced
this pull request
Jan 26, 2018
…5813-#58104-#58221-upstream-release-1.9 Automatic merge from submit-queue. Automated cherry pick of #55813: Add resource limits to prometheus-to-sd to guarantee qos #58104: Introduce METADATA_CONCEALMENT_NO_FIREWALL to prevent #58221: Bump metadata proxy to v1.9 Cherry pick of #55813 #58104 #58221 on release-1.9. #55813: Add resource limits to prometheus-to-sd to guarantee qos #58104: Introduce METADATA_CONCEALMENT_NO_FIREWALL to prevent #58221: Bump metadata proxy to v1.9 ```release-note GCP: allow a master to not include a metadata concealment firewall rule (if it's not running the metadata proxy), and reintroduce memory limits & bump metadata proxy to v0.1.9 to pick up security fixes. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: GCP: allow a master to not include a metadata concealment firewall rule (if it's not running the metadata proxy).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: