Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] Translate content/ja/docs/tasks/tools/_index.md #46030

Merged
merged 2 commits into from
May 4, 2024
Merged

[ja] Translate content/ja/docs/tasks/tools/_index.md #46030

merged 2 commits into from
May 4, 2024

Conversation

levi106
Copy link
Contributor

@levi106 levi106 commented Apr 26, 2024 •
edited
Loading

Fixes #45855

This pull request is for the translation of the latest content/en/docs/tasks/tools/_index.md.

Preview: https://deploy-preview-46030--kubernetes-io-main-staging.netlify.app/ja/docs/tasks/tools/

@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Apr 26, 2024
@k8s-ci-robot k8s-ci-robot requested a review from kakts April 26, 2024 15:46
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 26, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 26, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1aab86c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6634ee86ff598f0007536444
😎 Deploy Preview https://deploy-preview-46030--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Okabe-Junya
Copy link
Member

/cc

Okabe-Junya
Okabe-Junya approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

継続的なコントリビューションありがとうございます！

LGTMです！

@Okabe-Junya
Copy link
Member

/lgtm
/assign nasa9084

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d8a1c1751857b37c18e63e2a2a1ee57f7e1dacd0

inductor
inductor requested changes Apr 30, 2024
View reviewed changes
content/ja/docs/tasks/tools/_index.md Outdated

`kubectl`のダウンロードとインストールを行い、クラスターへのアクセスをセットアップする方法については、[kubectlのインストールおよびセットアップ](/ja/docs/tasks/tools/install-kubectl/)を参照してください。
kubectlはさまざまなLinuxプラットフォーム、macOS、Windows上にインストールできます。
下記の中からお好みのオペレーティングシステムを見つけてください。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「お好みのオペレーティングシステムを見つけてください。」
なんかこう直訳感がすごいので、もうちょっと自然な日本語っぽい感じにしたいですね

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。だいぶ意訳な感じですが、以下ではどうでしょうか？
「下記の中から使用しているオペレーティングシステムを選んでください。」

Copy link
Member

@Okabe-Junya Okabe-Junya Apr 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find your preferred operating system below.

なので個人的には either is fine だと思っています。leviさんのオリジナルを尊重 & 極力直訳に寄せるということであれば、

  • 下記の中から好きなオペレーティングシステムを選んでください

くらいでどうでしょうか

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。提案いただいた内容に変更しました。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応ありがとうございます！LGTM打ち直しておきますね

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2024
Okabe-Junya
Okabe-Junya approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2d4d03f7d2abd3b20e244831db65b5ba2fbb8ffc

@Okabe-Junya
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 3, 2024
inductor
inductor approved these changes May 4, 2024
View reviewed changes
Copy link
Member

@inductor inductor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inductor, Okabe-Junya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit e7656c6 into kubernetes:main May 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Okabe-Junya Okabe-Junya Okabe-Junya approved these changes

@inductor inductor inductor approved these changes

@bells17 bells17 Awaiting requested review from bells17

@kakts kakts Awaiting requested review from kakts

@nasa9084 nasa9084 Awaiting requested review from nasa9084

Assignees

@nasa9084 nasa9084

@Okabe-Junya Okabe-Junya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ja] Following the upstream for content/ja/docs/tasks/tools/_index.md
5 participants
@levi106 @Okabe-Junya @k8s-ci-robot @inductor @nasa9084