Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(UI): Updating Otel Demo Proto #3332

Merged
merged 2 commits into from
Nov 3, 2023
Merged

chore(UI): Updating Otel Demo Proto #3332

merged 2 commits into from
Nov 3, 2023

Conversation

xoscar
Copy link
Contributor

@xoscar xoscar commented Nov 3, 2023

This PR updates the broken otel demo protobuf to use the new names and methods

Changes

  • Updates the demo constants
  • Updates the proto file

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar marked this pull request as ready for review November 3, 2023 00:17
@xoscar xoscar merged commit 95b3ef3 into main Nov 3, 2023
38 checks passed
@xoscar xoscar deleted the chore/updating-otel-demo-proto branch November 3, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbdias danielbdias danielbdias approved these changes

@jorgeepc jorgeepc jorgeepc approved these changes

@mathnogueira mathnogueira mathnogueira approved these changes

@schoren schoren Awaiting requested review from schoren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xoscar @mathnogueira @jorgeepc @danielbdias