Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): use api-key from env on entrypoint cmd #4007

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

schoren
Copy link
Contributor

@schoren schoren commented Sep 3, 2024

This PR changes the entrypoint script to use the API KEY from env instead of as an argument when calling tracetest. This avoids exposing the API KEY as plain text under some circumstances

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

Add your loom video here if your work can be visualized

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 6:28pm

@schoren schoren changed the title security(agent): stop leaking api-key on entrypoint cmd fix(agent): use api-key from env on entrypoint cmd Sep 3, 2024
@schoren schoren merged commit ad3dd79 into main Sep 5, 2024
38 checks passed
@schoren schoren deleted the agent-docker-apikey-env branch September 5, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants