Allow create tests with existing ID #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+85
to
+88
| test, exists, err := a.createTestFromDefinition(ctx, definition) | ||
| if err != nil { | ||
| return runTestOutput{}, fmt.Errorf("could not create test from definition: %w", err) | ||
| } |
There was a problem hiding this comment.
Instead of changing how createTestFromDefinition works, why don't you call a.client.ApiApi.GetTest(ctx, id). If it returns an empty test, you create a new one. If not, you call updateTestFromDefinition.
There was a problem hiding this comment.
I think this approach is more flexible, because we are not duplicating the logic of verifying if a test exists. If at some point we decide to change that logic to check things besides the ID, this method wouldn't work anymore and we'd need to update both the client and the server
mathnogueira
approved these changes
Jun 23, 2022
d65c560
to
13d5e3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows creating tests with existing ID
Checklist