Fix compilation error on Ubuntu 18.04 (ROS Melodic) #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102. Seems 3.1.3 is the oldest version that supports this option (I couldn't find that option in CMake 3.0.0). Personally I think it's safe to assume that people using Ubuntu 16.04 have CMake 3.1.3 or higher, since 3.2.2 was released in 2015 for Xenial.
Apart from the compilation issue (which is resolved with this PR), I can't seem to run the demo bag file.
multiScanRegistrationnode crashes inextractFeatures.Currently looking into this, but it may be due to some API change in the pcl.#71 (comment) fixed this issue. I'll submit a PR to update the README, since many people seem to be suffereing from this issue.