-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix storage options for dataset builder #3156
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix looks reasonable, but we don't have a test for it, which worries me.
Do you know why this test doesn't catch it?
lance/python/python/tests/test_s3_ddb.py
Lines 230 to 243 in d79e870
@pytest.mark.integration | |
def test_s3_ddb_distributed_commit(s3_bucket: str, ddb_table: str): | |
table_name = uuid.uuid4().hex | |
table_dir = f"s3+ddb://{s3_bucket}/{table_name}?ddbTableName={ddb_table}" | |
schema = pa.schema([pa.field("a", pa.int64())]) | |
fragments = write_fragments( | |
pa.table({"a": pa.array(range(1024))}), | |
f"s3+ddb://{s3_bucket}/distributed_commit?ddbTableName={ddb_table}", | |
storage_options=CONFIG, | |
) | |
operation = lance.LanceOperation.Overwrite(schema, fragments) | |
ds = lance.LanceDataset.commit(table_dir, operation, storage_options=CONFIG) | |
assert ds.count_rows() == 1024 |
Would it catch this if we added an append part to that test?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3156 +/- ##
==========================================
+ Coverage 77.95% 77.98% +0.03%
==========================================
Files 242 242
Lines 81904 82441 +537
Branches 81904 82441 +537
==========================================
+ Hits 63848 64292 +444
- Misses 14890 14952 +62
- Partials 3166 3197 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@wjones127 could you please review it again? |
No description provided.