Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor contribution improvements to streamline on-boarding #173

Merged
merged 5 commits into from
Mar 17, 2023

Conversation

HunterGerlach
Copy link
Contributor

No description provided.

Copy link
Collaborator

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

largely lgtm modulo the integration test stuff

@HunterGerlach
Copy link
Contributor Author

Removed integration update+ref

@HunterGerlach HunterGerlach requested a review from nfcampos March 2, 2023 23:42
To run all tests, run:

```bash
yarn test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command would run only unit tests

@nfcampos nfcampos self-assigned this Mar 16, 2023
@nfcampos nfcampos added the lgtm PRs that are ready to be merged as-is label Mar 17, 2023
@nfcampos nfcampos merged commit 4eba2f6 into langchain-ai:main Mar 17, 2023
jacoblee93 pushed a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PRs that are ready to be merged as-is
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants