NotionAPILoader: Fix for #2807 and add propertiesAsHeader option
#2837
+71
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding an option to prepend page properties as a front matter header - Adds tests for new behaviour and propertiesAsHeader - Update the database example to include propertiesAsHeader
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -53,11 +53,53 @@ test("Test Notion API Loader onDocumentLoad", async () => { | |||
| `Loaded ${currentTitle} from ${rootTitle}: (${current}/${total})` | |||
There was a problem hiding this comment.
Hey there! Just wanted to flag that this PR explicitly accesses environment variables via process.env. Please review this change to ensure it aligns with security and best practices.
| @@ -53,11 +53,53 @@ test("Test Notion API Loader onDocumentLoad", async () => { | |||
| `Loaded ${currentTitle} from ${rootTitle}: (${current}/${total})` | |||
There was a problem hiding this comment.
Hey there! Just wanted to flag that this PR explicitly accesses environment variables via process.env. Please review this change to ensure it aligns with security and best practices.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2807
Notion databases are often used as the data stored in the page properties, with an empty page. This means a user may expect a similarity search on the page properties. I have enabled an option where a user can prepend the page properties as a frontmatter header to enable similarity search.
It was bought to my attention that the preferred behaviour for the Document class is to not create documents with empty
pageContents.This PR addresses both of these issues.
pageContentspages do not create DocumentsIt also