fix(stream): Update "IterableReadableStream" pull method to enqueue nullish data (e.g. empty string) #2839
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ullish data (e.g. empty string)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I think what you have is the correct behavior |
|
Huge fix, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address the issue our team identified while we were integrating
BaseLLMwith our own AI to enable the streaming capability. The issue we faced was, after we implemented*_streamResponseChunksgenerator function, we noticed it did not terminated in many cases.After investigation, we found out that our response stream would end by yielding empty string, and this behavior, paired with
IterableReadableStream's pull method, which only enqueue's value if it is not nullish, will hang the generator. Hence preventing it from terminating successfully.