Fix: Convert Neo4j Integers to strings in the result sets #2841
+159
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -3,7 +3,7 @@ | |||
| import { test } from "@jest/globals"; | |||
There was a problem hiding this comment.
This comment flags the change in the PR to review the explicit access of environment variables via process.env in the added test for the Neo4j database instantiation and connection.
So the LLMs can interpret them correctly. Added to test.
268bedb to
b4dee85
Compare
Also a bit of refactor to make sure we close the connection after each test.
|
LGTM :) thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the LLMs can interpret them correctly.
Added to test.
Also updated some of the code to use best practices.
About me:
Twitter handle: @oskarhane