Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: laravel/octane
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.2.10
Choose a base ref
...
head repository: laravel/octane
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.2.11
Choose a head ref
  • 3 commits
  • 4 files changed
  • 3 contributors

Commits on May 17, 2022

  1. Update CHANGELOG

    driesvints authored and github-actions[bot] committed May 17, 2022

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    9099946 View commit details

Commits on May 18, 2022

  1. test flushing logger shared context (#514)

    * test flushing logger shared context
    
    * ignore Laravel 8
    
    * style
    timacdonald authored May 18, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    5efb83d View commit details

Commits on May 20, 2022

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    f0cb7b8 View commit details
Showing with 45 additions and 2 deletions.
  1. +11 −1 CHANGELOG.md
  2. +1 −0 src/RoadRunner/ServerProcessInspector.php
  3. +32 −0 tests/Listeners/FlushLogContextTest.php
  4. +1 −1 tests/RoadRunnerServerProcessInspectorTest.php
12 changes: 11 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
# Release Notes

## [Unreleased](https://github.com/laravel/octane/compare/v1.2.9...1.x)
## [Unreleased](https://github.com/laravel/octane/compare/v1.2.10...1.x)

## [v1.2.10](https://github.com/laravel/octane/compare/v1.2.9...v1.2.10) - 2022-05-13

### Changed

- Revert PaginationState to resolve using new instance of the app by @farmani in https://github.com/laravel/octane/pull/519

### Fixed

- Warm transaction manager by @taylorotwell in https://github.com/laravel/octane/commit/752d02dc5973a11bf55f332eee0d9e5566442519

## [v1.2.9](https://github.com/laravel/octane/compare/v1.2.8...v1.2.9) - 2022-05-10

1 change: 1 addition & 0 deletions src/RoadRunner/ServerProcessInspector.php
Original file line number Diff line number Diff line change
@@ -51,6 +51,7 @@ public function reloadServer(): void
$this->findRoadRunnerBinary(),
'reset',
'-o', "rpc.listen=tcp://$host:$rpcPort",
'-s',
], base_path()))->start()->waitUntil(function ($type, $buffer) {
if ($type === Process::ERR) {
throw new RuntimeException('Cannot reload RoadRunner: '.$buffer);
32 changes: 32 additions & 0 deletions tests/Listeners/FlushLogContextTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?php

namespace Laravel\Octane\Listeners;

use Illuminate\Foundation\Application;
use Illuminate\Http\Request;
use Laravel\Octane\Tests\TestCase;

class FlushLogContextTest extends TestCase
{
public function test_shared_context_is_flushed()
{
if (version_compare(Application::VERSION, '9.0.0', '<')) {
$this->markTestSkipped('Shared context is only supported in Laravel 9+');
}

[$app, $worker, $client] = $this->createOctaneContext([
Request::create('/', 'GET'),
]);
$app['router']->middleware('web')->get('/', function () {
// ..
});
$log = $app['log'];
$log->shareContext(['shared' => 'context']);

$this->assertSame(['shared' => 'context'], $log->sharedContext());

$worker->run();

$this->assertSame([], $log->sharedContext());
}
}
2 changes: 1 addition & 1 deletion tests/RoadRunnerServerProcessInspectorTest.php
Original file line number Diff line number Diff line change
@@ -62,7 +62,7 @@ public function test_roadrunner_server_process_can_be_reloaded()
]);

$processFactory->shouldReceive('createProcess')->with(
[$this->findRoadRunnerBinary(), 'reset', '-o', 'rpc.listen=tcp://127.0.0.1:6002'],
[$this->findRoadRunnerBinary(), 'reset', '-o', 'rpc.listen=tcp://127.0.0.1:6002', '-s'],
base_path(),
)->andReturn($process = Mockery::mock('stdClass'));