Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.10] update exporting metrics docs #979

Merged
merged 3 commits into from
Mar 10, 2021

Conversation

Pothulapati
Copy link
Contributor

This PR updates the Exporting Metrics doc to reflect the changes
that happened with 2.10

Signed-off-by: Tarun Pothulapati [email protected]

This PR updates the `Exporting Metrics` doc to reflect the changes
that happened with 2.10

Signed-off-by: Tarun Pothulapati <[email protected]>
Copy link
Contributor

@dadjeibaah dadjeibaah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📦 🚢

Copy link
Member

@adleong adleong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should edit the introduction at the start of this page to give the proper context that Promtheus is part of the Viz extension and the instructions on this page requiring having the viz extension installed

@@ -135,7 +135,7 @@ Similar to the `/federate` API, Prometheus provides a JSON query API to
retrieve all metrics:

```bash
curl http://linkerd-prometheus.linkerd.svc.cluster.local:9090/api/v1/query?query=request_total
curl http://prometheus.linkerd-viz.svc.cluster.local:9090/api/v1/query?query=request_total
```

## Gathering data from the Linkerd proxies directly {#proxy}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention the linkerd diagnostics proxy-metrics command?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely makes sense to add this.

@Pothulapati
Copy link
Contributor Author

@adleong Updated.

Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Pothulapati Pothulapati merged commit 8bb8ca8 into release/2.10 Mar 10, 2021
@olix0r olix0r deleted the tarun/exposing-metrics branch August 25, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants