-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.10] update exporting metrics docs #979
Conversation
This PR updates the `Exporting Metrics` doc to reflect the changes that happened with 2.10 Signed-off-by: Tarun Pothulapati <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📦 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should edit the introduction at the start of this page to give the proper context that Promtheus is part of the Viz extension and the instructions on this page requiring having the viz extension installed
@@ -135,7 +135,7 @@ Similar to the `/federate` API, Prometheus provides a JSON query API to | |||
retrieve all metrics: | |||
|
|||
```bash | |||
curl http://linkerd-prometheus.linkerd.svc.cluster.local:9090/api/v1/query?query=request_total | |||
curl http://prometheus.linkerd-viz.svc.cluster.local:9090/api/v1/query?query=request_total | |||
``` | |||
|
|||
## Gathering data from the Linkerd proxies directly {#proxy} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention the linkerd diagnostics proxy-metrics
command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely makes sense to add this.
Signed-off-by: Tarun Pothulapati <[email protected]>
Signed-off-by: Tarun Pothulapati <[email protected]>
@adleong Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This PR updates the
Exporting Metrics
doc to reflect the changesthat happened with 2.10
Signed-off-by: Tarun Pothulapati [email protected]