Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI for editing .env file #218

Merged
merged 6 commits into from
Dec 3, 2023
Merged

UI for editing .env file #218

merged 6 commits into from
Dec 3, 2023

Conversation

syko9000
Copy link
Contributor

@syko9000 syko9000 commented Dec 1, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/dockge/blob/master/CONTRIBUTING.md

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Presents and highlights the contents of the stack folder's .env file in the UI. Allows editing and saving. Also adds $token highlighting to YAML editor.

Type of change

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Screenshot 2023-12-01 at 8 35 41 AM

@louislam louislam added this to the 1.3.0 milestone Dec 1, 2023
Copy link
Contributor

@Zaid-maker Zaid-maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing feature! 😄

@Zaid-maker
Copy link
Contributor

LF and CRLF issue

@louislam
Copy link
Owner

louislam commented Dec 3, 2023

LF and CRLF issue

Seems like a random runner bug, there is no CRLF in the file, it passed after re-run without changes.

@louislam louislam merged commit a8d95d0 into louislam:master Dec 3, 2023
6 checks passed
@Zaid-maker
Copy link
Contributor

LF and CRLF issue

Seems like a random runner bug, there is no CRLF in the file, it passed after re-run without changes.

Ohhh OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants