Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve formatting #1814

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Improve formatting #1814

merged 5 commits into from
Feb 1, 2024

Conversation

nix6839
Copy link
Contributor

@nix6839 nix6839 commented Jan 19, 2024 •
edited
Loading

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other: Improve formatting

Description

  • Ignore examples in docs/ from linting.
  • Separate format script and lint:format script in package.json -> Now, instead of formatting on CI, properly perform checks on formatting.
  • Update some rules.
  • Run formatting.

Before Submitting

@github-actions github-actions bot added 🌍 site Has to do something with the Lucide website ⚛️ react package Lucide React Package 💎 vue package Lucide Vue package ⚛️ preact package About the Preact Package 🧳 lucide package About the lucide package 🧣 svelte package About the Svelte package ⚛️ react native package About the React Native package 🫧 metadata Improved metadata 🅰️ angular package About the Angular package 🪨 static package About the static package labels Jan 19, 2024
@github-actions github-actions bot added 📦 dependencies Pull requests that update a dependency file 🪝 solid package About the Solid package labels Jan 29, 2024
@nix6839 nix6839 changed the title Run format Improve formatting Jan 31, 2024
ericfennis
ericfennis approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always a pain to review these massive PRs. Checked everything.
Nice to have everything formatted correctly.

@nix6839 Thanks a lot!

@ericfennis ericfennis merged commit eb035fe into lucide-icons:main Feb 1, 2024
4 checks passed
@nix6839 nix6839 deleted the format branch February 1, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericfennis ericfennis ericfennis approved these changes

Assignees
No one assigned
Labels
🅰️ angular package About the Angular package 📦 dependencies Pull requests that update a dependency file 🧳 lucide package About the lucide package 🫧 metadata Improved metadata ⚛️ preact package About the Preact Package ⚛️ react native package About the React Native package ⚛️ react package Lucide React Package 🌍 site Has to do something with the Lucide website 🪝 solid package About the Solid package 🪨 static package About the static package 🧣 svelte package About the Svelte package 💎 vue package Lucide Vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nix6839 @ericfennis