Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): made the venetian-mask icon a bit bigger and change the eye whole shape to a single line to not violate the 2px gap rule #1950

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Mar 7, 2024

What is the purpose of this pull request?

  • Other: Icon update

Description

Made the mask a bit bigger and change the eye whole shape to a single line to not violate the 2px gap rule.

Before Submitting

Copy link

github-actions bot commented Mar 7, 2024

Added or changed icons

icons/venetian-mask.svg

Preview cohesion icons/square-chevron-up.svg
icons/venetian-mask.svg
icons/mouse-pointer.svg
Preview stroke widths icons/venetian-mask.svg
icons/venetian-mask.svg
icons/venetian-mask.svg
DPI Preview (24px) icons/venetian-mask.svg
Icon X-rays icons/venetian-mask.svg
Icon Diffs icons/venetian-mask.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const VenetianMaskIcon = createLucideIcon('VenetianMask', [
  ["path",{"d":"M18 11c-1.5 0-2.5.5-3 2"}],
  ["path",{"d":"M4 6a2 2 0 0 0-2 2v4a5 5 0 0 0 5 5 8 8 0 0 1 5 2 8 8 0 0 1 5-2 5 5 0 0 0 5-5V8a2 2 0 0 0-2-2h-3a8 8 0 0 0-5 2 8 8 0 0 0-5-2z"}],
  ["path",{"d":"M6 11c1.5 0 2.5.5 3 2"}]
])

@karsa-mistmere
Copy link
Member

I'm not totally sure it's recognisable enough 🤔, also, the added height throws off vertical centering.

@jguddas
Copy link
Member Author

jguddas commented Mar 7, 2024

It feels pretty centerish icons/messages-square.svg icons/venetian-mask.svg icons/list-collapse.svg

@github-actions github-actions bot added the Stale label Apr 7, 2024
@ericfennis ericfennis merged commit 407b55f into lucide-icons:main Nov 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants