-
-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lucide-svelte): Aliased imports for direct imports #2584
Conversation
I've published a beta version on |
…x-svelte-alias-specific-imports
This unfortunately broke
|
@kaechele is this still happening when removing and reinstalling npm packages? |
Yes, this still happens even on a completely fresh checkout of my project. Looking at the contents of the |
I was hit by this as well in version 0.458.0: #2614 |
Closes #2580
What is the purpose of this pull request?
Description
This is a new setup for the build process, making importing aliased imports possible.
To make it work I had to make some additions to the build process that generates the aliases files.
The
.ts
file addition is needed to point to the correct icon files.I've tried to do it just with
.svelte
files, but there is a difference in how Sveltekit and Vite read the imports map inpackage.json
. Sveltekit ignores thedefault
in the imports map when it tries to do SSR.Current output:
Note: The build scripts are getting a bit complex, some refactoring in the future will be nice.