Make discount table columns toggleable#2172
Merged
alecritson merged 4 commits intolunarphp:1.xfrom Apr 25, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alecritson
reviewed
Apr 24, 2025
alecritson
approved these changes
Apr 25, 2025
Beaudinn
pushed a commit
to Webhoek/lunar
that referenced
this pull request
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds toggling to the discount table columns, and adding coupon and created at columns, hidden by default.
It makes the name, coupon and date fields sortable.
And it adds a unique validation on the coupon field, as currently you can add discount codes with the same coupon which throws an unhandled database error.