This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Avoid executing no-op queries. #16583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3453eba
to
e6010d1
Compare
erikjohnston
reviewed
Nov 1, 2023
erikjohnston
approved these changes
Nov 3, 2023
|
I'm not 100% convinced of these changes, I want to add some tests. |
|
Once #16596 is merged, I'll add tests for these changes to ensure nothing is breaking. |
|
I added some additional tests (based on #16596) and some more comments. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return early for
simple_insert_many_txn,simple_upsert_many_txn, andsimple_update_many_txnif the iterable to update is empty.Note that we already do this for
simple_select_many_txnandsimple_delete_many_txn.This avoids hitting the database with a no-op query, the downside is that we can't pass generators into this function.