This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Simplify persistance code #16584
Merged
Simplify persistance code #16584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf721d3
to
db97d2e
Compare
db97d2e
to
3157522
Compare
Frequently only a single event is persisted at a time so this will not have an impact, but when multiple events are persisted at once then there is no need to continually update the stream change cache *except* for the last change.
erikjohnston
approved these changes
Nov 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only ever persist events for a single room at once, but the code handles multiple rooms at once this:
I'm not sure if this is desirable if we ever want to be able to persist from multiple rooms at once, but... 🤷
The first commit factors out a method, so should be reviewed separately.