feat: Copy and send notification when user click "This device" menu #9
+33
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This possibly makes goroutine leak since this part is called multiple times. |
|
the fix might be a bit complicated for now |
mattn
reviewed
Oct 15, 2021
main.go
Outdated
| @@ -131,6 +138,30 @@ func onReady() { | |||
| mDisconnect.Enable() | |||
| systray.SetIcon(iconOn) | |||
| enabled = true | |||
|
|
|||
| go func(mThisDevice *systray.MenuItem) { | |||
There was a problem hiding this comment.
If this part is passed twice, goroutine is created two.
There was a problem hiding this comment.
🤔 Let me debug it again
There was a problem hiding this comment.
building...
running...
ts-called goroutine id: 1634266073 # first loop cycle
# I made-up error intentionally (dynamically without closing program) on tailscale exec call, this will send "closing" signal to enabledCh
ts-closed goroutine id: 1634266073 # this goroutine close was triggered by enabledCh
# I remove the made-up error
ts-called goroutine id: 1634266103 # The click listener active again after if !enable { enable = true }
^Ccleaning...
see you again~ 
There was a problem hiding this comment.
The groutine part should be moved out of for loop.
There was a problem hiding this comment.
Is it like this?
Lines 72 to 80 in a06d2c1
|
Probably LGTM. Will look tonight. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.