fix: can focus combobox items (#679)

[yeonsubak]

/claim #679

description

• Update @radix-ui/react-popover to ^1.1.2 that eventually fix the focusing issue of the combobox items.

related issue: #679 #654

type of change

• bug fix
• new feature
• breaking change
• documentation update

how to test

1. Make sure to have "@radix-ui/react-popover": "^1.1.2" under dependencies in /screenpipe-app-tauri/package.json
2. Run bun install from /screenpipe-app-tauri in your terminal to update @radix-ui/react-popover
3. Run bun tauri dev
4. Once the application has started, go to Settings menu and check the following combobox elements are properly working
   • monitors
   • audio devices
   • languages

if relevant add screenshots or screen captures to prove that this PR works to save us time.

screenpipe-pr-issue-679.mp4

checklist

• MOST IMPORTANT: this PR will require less than 30 min to review, merge, and release to production and not crash in the hand of thousands of users
• i have read the CONTRIBUTING.md file
• i have updated the documentation if necessary
• my changes generate no new warnings
• i have added tests that prove my fix is effective or that my feature works

additional notes

I tried inspecting related components from shadcn library but they all looked good and don't seem to cause the issue. Just out of the intuition, I suspected that it's caused by the Popover component of radix-ui so I updated it to the latest version and it eventually worked.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
screenpipe	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 16, 2024 2:57pm

[louis030195]

/approve

amazing thanks

[algora-pbc]

Could not find a claim that corresponds to the PR. Please add the /claim snippet to the PR body first.

[louis030195]

@yeonsubak can you add the claim for bounty plz

[algora-pbc]

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

[yeonsubak]

@yeonsubak can you add the claim for bounty plz

Thanks! I added the claim on my PR body.

[louis030195]

/approve

[algora-pbc]

@louis030195: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment.

[louis030195]

Screen.Recording.2024-11-18.at.11.00.29.AM.mov

i did not test the change and actually it did not work ...

[yeonsubak]

Screen.Recording.2024-11-18.at.11.00.29.AM.mov
i did not test the change and actually it did not work ...

Thanks for the feedback! I will check it out.
Can you explain how to navigate to that page in the video or list other pages that I can look into?

First, let me try modify Command component as I introduced in shadcn's PR. If it doesn't work, I will thoroughly inspect the elements and their dynamics in the page.

[yeonsubak]

@louis030195 Actually, I ran both bun tauri dev and compiled screenpipe-app.exe without modifying any codes from commit 478fb05 and it seems to be working well.

Could you please check whether the dependency update actually happened in your CI/CD?

how to test

1. Make sure to have "@radix-ui/react-popover": "^1.1.2" under dependencies in /screenpipe-app-tauri/package.json
2. Run bun install from /screenpipe-app-tauri in your terminal to update @radix-ui/react-popover

screenpipe-issue-679-2.mp4

screenpipe-issue-679-3.mp4