Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization and Widgets upgrade #14

Merged
merged 15 commits into from
Jan 28, 2015
Merged

Conversation

nontas
Copy link
Member

@nontas nontas commented Jan 3, 2015

This PR upgrades the visualization widgets of menpofit in order to follow the improvements made by PR #530 of menpo (menpo/menpo#530). Specifically:

Widgets

visualize_shape_model(), visualize_appearance_model(), visualize_aam(), visualize_atm(), visualize_fitting_results(), plot_ced(): All menpofit widgets are now fixed. They all have a viewer options tab that specifies options related to the lines, markers, numbering, legend, axes, grid, figure and image. Note that in the case of a landmark group with multiple labels, the user can define a different colour per label. Finally, all widgets now have Menpo's logo.

Visualization

  • plot_cumulative_error_distribution(), plot_errors(), plot_displacements(): These methods are added to the FittingResult class. plot_cumulative_error_distribution() allows the plotting of multiple error curves and is also utilized by the plot_ced() widget. The other two methods plot the errors() and displacements_stats() of the FittingResult class. All three methods use GraphPlotter class (thus MatplotlibGraphPlotter) and get as arguments all the rendering options related to the lines, markers, legend, axes, grid, figure and labels.
  • view_shape_models_widget(), view_appearance_models_widget(), view_aam_widget(), view_atm_widget(): The previous view_widget() methods of AAM, ATM and CLM classes are now replaced by more explicit ones. Specifically, AAM has view_shape_models_widget(), view_appearance_models_widget(), view_aam_widget(), ATM has view_shape_models_widget(), view_atm_widget() and CLM has view_shape_models_widget().

Note that I moved some widget-related function from menpo.visualize.options to menpofit.visualize.options, since they were only used by menpofit's widget main functions.

This PR depends on menpo/menpo#530 and should get accepted after merging that one first.

@nontas
Copy link
Member Author

nontas commented Jan 27, 2015

This is now ready! It can be pulled as soon as menpo/menpo#530 is merged.
+1

lenna is now an ljson and therefore all the tests that assumed
every image was landmarked with PTS started failing.

Also, unpin menpofit from menpo 0.4.0a3 and let if find the master
branch so that the tests have a chance of passing.
@patricksnape
Copy link
Contributor

+1 Tests pass.

patricksnape pushed a commit that referenced this pull request Jan 28, 2015
Visualization and Widgets upgrade
@patricksnape patricksnape merged commit e427b28 into menpo:master Jan 28, 2015
@nontas nontas deleted the widgets_upgrade branch January 28, 2015 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants