-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualization and Widgets upgrade #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now ready! It can be pulled as soon as menpo/menpo#530 is merged. |
lenna is now an ljson and therefore all the tests that assumed every image was landmarked with PTS started failing. Also, unpin menpofit from menpo 0.4.0a3 and let if find the master branch so that the tests have a chance of passing.
+1 Tests pass. |
patricksnape
pushed a commit
that referenced
this pull request
Jan 28, 2015
Visualization and Widgets upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the visualization widgets of
menpofit
in order to follow the improvements made by PR #530 ofmenpo
(menpo/menpo#530). Specifically:Widgets
visualize_shape_model(), visualize_appearance_model(), visualize_aam(), visualize_atm(), visualize_fitting_results(), plot_ced(): All
menpofit
widgets are now fixed. They all have a viewer options tab that specifies options related to the lines, markers, numbering, legend, axes, grid, figure and image. Note that in the case of a landmark group with multiple labels, the user can define a different colour per label. Finally, all widgets now have Menpo's logo.Visualization
FittingResult
class.plot_cumulative_error_distribution()
allows the plotting of multiple error curves and is also utilized by theplot_ced()
widget. The other two methods plot theerrors()
anddisplacements_stats()
of theFittingResult
class. All three methods useGraphPlotter
class (thusMatplotlibGraphPlotter
) and get as arguments all the rendering options related to the lines, markers, legend, axes, grid, figure and labels.view_widget()
methods ofAAM
,ATM
andCLM
classes are now replaced by more explicit ones. Specifically,AAM
hasview_shape_models_widget()
,view_appearance_models_widget()
,view_aam_widget()
,ATM
hasview_shape_models_widget()
,view_atm_widget()
andCLM
hasview_shape_models_widget()
.Note that I moved some widget-related function from
menpo.visualize.options
tomenpofit.visualize.options
, since they were only used bymenpofit
's widget main functions.This PR depends on menpo/menpo#530 and should get accepted after merging that one first.