Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 01 - ROS and Sensor Fusion Tutorial.md #1

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

ricber
Copy link
Contributor

@ricber ricber commented Mar 15, 2019

Swapped "odom -> base_link" and "map -> odom" paragraph titles

Swapped "odom -> base_link" and "map -> odom" paragraph titles
@methylDragon
Copy link
Owner

Hiya! Thanks for spotting the mistake, though the issue is the description and not the titles (that, and the outer titles needed to be fixed as well, haha...)

I'll close and merge in the pull request and make further edits.

CH3EERS!

@methylDragon methylDragon merged commit 491012c into methylDragon:master Mar 15, 2019
@ricber
Copy link
Contributor Author

ricber commented Mar 15, 2019

Sorry, just a last little thing, in Fusing Sensors for the /map frame (map -> odom) shouldn't be

"All continuous sensor data and algorithm outputs that are global pose estimates"

instead of

"All continuous sensor data and algorithm outputs that aren't global pose estimate"

@methylDragon
Copy link
Owner

Oh! Yeah, actually that's a very confusing point, I was surprised about it too, but if you check the diagram from Clearpath's lecture (https://github.com/methylDragon/ros-sensor-fusion-tutorial/blob/master/assets/1_5.png), they actually fuse non-global data for the global pose estimation Kalman filter!

Thanks for pointing out to me that this is a point of confusion, I'll add in a note to be clearer on that.

CH3EERS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants