Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some types of nodes do not read the node_data_json_file #4761

Closed
lynshi opened this issue Dec 15, 2022 · 1 comment · Fixed by #4762
Closed

Some types of nodes do not read the node_data_json_file #4761

lynshi opened this issue Dec 15, 2022 · 1 comment · Fixed by #4762
Labels

Comments

@lynshi
Copy link
Contributor

lynshi commented Dec 15, 2022

Describe the bug
The node_data_json_file file is supposed to be loaded by CCF on startup so that its contents can be returned as node_data as part of the node info. However, we do not see any node_data for a START node, though we can see node_data populated for subsequent JOIN nodes. I'm not sure what the behavior is for RECOVER nodes.

To Reproduce
Steps to reproduce the behavior.

  1. Create a node data file on disk with some information.
{
  "nodeName": "ccf-0",
  "vmName": "myVm"
}
  1. Create a configuration file for CCF including "node_data_json_file": "/path/to/node_data.json".
  2. Start the network.

The first node returns null for node_data.

{
  "nodes": [
    {
      "last_written": 1,
      "node_data": null,
      "node_id": "61d98178f9048aa6b9bcf0af641c49b3ba23d150a8410b0688284a2148b5906c",
      "primary": true,
      "rpc_interfaces": {
        "operator": {
          "bind_address": "10.240.7.117:16386",
          "endorsement": {
            "authority": "Node"
          },
          "published_address": "10.240.7.117:16386"
        },
        "primary": {
          "bind_address": "10.240.7.117:16385",
          "endorsement": {
            "authority": "Service"
          },
          "http_configuration": {
            "max_body_size": "1MB"
          },
          "published_address": "10.240.7.117:16385"
        }
      },
      "status": "Trusted"
    },
    {
      "last_written": 3,
      "node_data": {
        "kubernetesNamespace": "ccfcommontest4d3a-b00e-888e687cd955",
        "nodeName": "ccf-2",
        "vmName": "aks-nodepool2-27485096-vmss00000a"
      },
      "node_id": "3eb0a550d3ae5932df797d912983313f1ec8d926b63f5f71f85a20b9a480a061",
      "primary": false,
      "rpc_interfaces": {
        "operator": {
          "bind_address": "10.240.1.30:16386",
          "endorsement": {
            "authority": "Node"
          },
          "published_address": "10.240.1.30:16386"
        },
        "primary": {
          "bind_address": "10.240.1.30:16385",
          "endorsement": {
            "authority": "Service"
          },
          "http_configuration": {
            "max_body_size": "1MB"
          },
          "published_address": "10.240.1.30:16385"
        }
      },
      "status": "Trusted"
    },
    {
      "last_written": 4,
      "node_data": {
        "kubernetesNamespace": "ccfcommontest4d3a-b00e-888e687cd955",
        "nodeName": "ccf-1",
        "vmName": "aks-nodepool3-27485096-vmss000010"
      },
      "node_id": "ef937c9662a3fa9cb9452373accd096c60ec54f7c25caba56a904e219ed1b7b6",
      "primary": false,
      "rpc_interfaces": {
        "operator": {
          "bind_address": "10.240.19.12:16386",
          "endorsement": {
            "authority": "Node"
          },
          "published_address": "10.240.19.12:16386"
        },
        "primary": {
          "bind_address": "10.240.19.12:16385",
          "endorsement": {
            "authority": "Service"
          },
          "http_configuration": {
            "max_body_size": "1MB"
          },
          "published_address": "10.240.19.12:16385"
        }
      },
      "status": "Trusted"
    }
  ]
}

Expected behavior
The node info for the first node should include the contents of the node_data file.

Environment information
Version of the code being used, versions of dependencies, relevant environment info where applicable (OS, SGX driver...).
Version: CCF 2.0.13

Additional context
Add any other context about the problem here.

@achamayou
Copy link
Member

@lynshi released in https://github.com/microsoft/CCF/releases/tag/ccf-2.0.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants