Add test for secp256r1 as service and node identities curve
#2516
+51
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyashton
commented
Apr 27, 2021
Comment on lines
+350
to
+362
| crypto::CurveID curve_id = crypto::CurveID::SECP384R1; | ||
| std::vector<std::pair<std::string, crypto::CurveID>> curve_id_map = { | ||
| {"secp384r1", crypto::CurveID::SECP384R1}, | ||
| {"secp256r1", crypto::CurveID::SECP256R1}}; | ||
| app | ||
| .add_option( | ||
| "--curve-id", | ||
| curve_id, | ||
| "Elliptic curve to use as for node and network identities (used for TLS " | ||
| "and ledger signatures)") | ||
| ->transform(CLI::CheckedTransformer(curve_id_map, CLI::ignore_case)) | ||
| ->capture_default_str(); | ||
|
|
There was a problem hiding this comment.
Just moving this up, since its common to all subcommands (was previously amongst the start specific args).
|
curve_id_tests@24233 aka 20210427.21 vs main ewma over 20 builds from 23891 to 24212 Click to see table
|
achamayou
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: This still doesn't support mixed curves within a service. If a node tries to join with an identity generated on a different curve, it will currently be unable to form channels with other nodes.