Skip to content

Comments

add sideEffects false for tree-shaking in webpack#981

Merged
alexdima merged 1 commit intomicrosoft:masterfrom
mscolnick:patch-1
Aug 10, 2018
Merged

add sideEffects false for tree-shaking in webpack#981
alexdima merged 1 commit intomicrosoft:masterfrom
mscolnick:patch-1

Conversation

@mscolnick
Copy link
Contributor

No description provided.

@alexdima alexdima merged commit 5e178f8 into microsoft:master Aug 10, 2018
@alexdima alexdima added this to the July 2018 milestone Aug 10, 2018
@alexdima
Copy link
Member

alexdima commented Aug 13, 2018

I had to revert this, because it led to all the CSS imports being ignored...

@mscolnick
Copy link
Contributor Author

ah ok, sorry about that. the change should've been this:

  "sideEffects": [
    "*.css"
  ],

still ok if i submit the PR?

@alexdima
Copy link
Member

Sure, but can you please test the following before:

@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants