This repository was archived by the owner on Nov 5, 2021. It is now read-only.
SystemVerilog: Adding better syntax highlighting for primitive table definitions#165
Merged
alexdima merged 1 commit intomicrosoft:mainfrom Oct 11, 2021
Merged
Conversation
Member
|
Thank you! (The PR doesn't need a label because we will merge it --> https://hacktoberfest.digitalocean.com/#:~:text=Details ) |
Contributor
Author
|
@alexdima it looks like for this PR to be counted for Hacktoberfest it needs the 'hacktoberfest-accepted' label added, since the project doesn't have 'hacktoberfest' topic added. I confirmed it's not showing up in my list of completed PRs for Hacktoberfest. Would you mind adding the |
Member
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding better syntax highlighting for user-defined primitive tables, which have their own list of symbols defined by the language (0, 1, x, ?, b, -, *, r, f, p, n). Currently the identifiers and numbers are getting highlighted which looks OK, but adding a uniform style looks better.
Before:
After:
I'm participating in Hacktoberfest, so if this PR looks good and you don't mind, could you add the
hacktoberfest-acceptedlabel to it? Thanks a lot!