Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to go v1.24.1 #1428

Merged
merged 9 commits into from
Mar 13, 2025
Merged

chore: update to go v1.24.1 #1428

merged 9 commits into from
Mar 13, 2025

Conversation

nddq
Copy link
Contributor

@nddq nddq commented Mar 12, 2025

Description

Update to go v1.24.1, removed hack/tools in favor of the new go tool directive.

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

Siteproxy

Verified

This commit was signed with the committer’s verified signature.
nddq Quang Nguyen
@nddq nddq added the area/dependencies Pull requests that update a dependency file label Mar 12, 2025
@nddq nddq self-assigned this Mar 12, 2025
@nddq nddq requested a review from a team as a code owner March 12, 2025 23:25
nddq added 2 commits March 12, 2025 19:27

Verified

This commit was signed with the committer’s verified signature.
nddq Quang Nguyen

Verified

This commit was signed with the committer’s verified signature.
nddq Quang Nguyen
@nddq nddq changed the title chore: update to go1.24 chore: update to go v1.24.1 Mar 12, 2025
nddq added 4 commits March 12, 2025 19:36

Verified

This commit was signed with the committer’s verified signature.
nddq Quang Nguyen

Verified

This commit was signed with the committer’s verified signature.
nddq Quang Nguyen

Verified

This commit was signed with the committer’s verified signature.
nddq Quang Nguyen

Verified

This commit was signed with the committer’s verified signature.
nddq Quang Nguyen
@nddq
Copy link
Contributor Author

nddq commented Mar 13, 2025

Agent and operator trivy scans
image
image

rayaisaiah
rayaisaiah previously approved these changes Mar 13, 2025
@rayaisaiah rayaisaiah added this pull request to the merge queue Mar 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2025
@rayaisaiah rayaisaiah added this pull request to the merge queue Mar 13, 2025
@nddq nddq removed this pull request from the merge queue due to a manual request Mar 13, 2025
@nddq
Copy link
Contributor Author

nddq commented Mar 13, 2025

something is wrong with the final image build, init container is stuck in crashloop

Verified

This commit was signed with the committer’s verified signature.
nddq Quang Nguyen
@nddq
Copy link
Contributor Author

nddq commented Mar 13, 2025

should be good now, something went wrong when using go tool with bpf2go so I have reverted it. It is out of scope for this PR anyways so we can look into it some other time.

rayaisaiah
rayaisaiah previously approved these changes Mar 13, 2025
@rayaisaiah rayaisaiah added this pull request to the merge queue Mar 13, 2025
github-merge-queue bot pushed a commit that referenced this pull request Mar 13, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
# Description

Update to go v1.24.1, removed `hack/tools` in favor of the new `go tool`
directive.
## Related Issue

If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.

## Checklist

- [ ] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes
made.

## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
@nddq nddq removed this pull request from the merge queue due to a manual request Mar 13, 2025

Verified

This commit was signed with the committer’s verified signature.
nddq Quang Nguyen
@nddq nddq enabled auto-merge March 13, 2025 22:43
@nddq nddq added this pull request to the merge queue Mar 13, 2025
Merged via the queue into main with commit 2e37674 Mar 13, 2025
29 checks passed
@nddq nddq deleted the chore/go1.24 branch March 13, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants