Log number of interactive sessions #17682
Merged
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
DHowett
reviewed
Aug 7, 2024
DHowett
approved these changes
Aug 7, 2024
lhecker
approved these changes
Aug 8, 2024
| @@ -42,6 +42,7 @@ class WindowThread : public std::enable_shared_from_this<WindowThread> | |||
| winrt::event_token _UpdateSettingsRequestedToken; | |||
|
|
|||
| std::unique_ptr<::IslandWindow> _warmWindow{ nullptr }; | |||
| static bool _loggedInteraction; | |||
There was a problem hiding this comment.
You don't need to attach statics to classes. It's just fine to have mutable statics inside functions. If they're of trivial types (bool, int, float, etc.) there's no difference. (For complex types there's a difference: Class statics get initialized like globals on startup and function statics get initialized the first time execution passes over them.)
DHowett
pushed a commit
that referenced
this pull request
Aug 13, 2024
This sends a telemetry event if a session is interacted with. Specifically, key events are essential to have an interactive session in Windows Terminal, so we're tracking sessions that have had a key down event. (cherry picked from commit ac865e6) Service-Card-Id: 93498660 Service-Version: 1.21
DHowett
pushed a commit
that referenced
this pull request
Aug 13, 2024
This sends a telemetry event if a session is interacted with. Specifically, key events are essential to have an interactive session in Windows Terminal, so we're tracking sessions that have had a key down event. (cherry picked from commit ac865e6) Service-Card-Id: 93498659 Service-Version: 1.20
carlos-zamora
added a commit
that referenced
this pull request
Jan 15, 2025
Adds a description and keyword for the `SessionBecameInteractive` event Follow-up from #17682
DHowett
pushed a commit
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sends a telemetry event if a session is interacted with. Specifically, key events are essential to have an interactive session in Windows Terminal, so we're tracking sessions that have had a key down event.