-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Comparing changes
Open a pull request
base repository: microsoft/winget-cli
base: v1.9.25180
head repository: microsoft/winget-cli
compare: v1.10.30-preview
- 16 commits
- 172 files changed
- 7 contributors
Commits on Oct 11, 2024
-
Make adding overlapping ARP range a hard error (#4870)
## Change Implements two independent but related changes: 1. Makes adding/updating an overlapping ARP range a hard error 2. Adds `AddOrUpdate` functionality to the index so that callers don't need to know if the manifest is already present ## Validation Added/updated unit tests for ARP overlap. Added unit and interop test for AddOrUpdate.
Configuration menu - View commit details
-
Copy full SHA for e80ca4a - Browse repository at this point
Copy the full SHA e80ca4aView commit details
Commits on Oct 14, 2024
-
In coded lines, the clock ticks on, From dawn to dusk, until it’s gone. Versions rise with whispered lore, From simple roots, to something more. Bugs are squashed, new feats take flight, Updates cascade in endless light. Yet in each change, a piece remains, A bit of history in the gains. Time’s passage [A series of tokens deemed reasonably likely by an artificial neural network when provided with some other tokens generated by a biological neural network.]
Configuration menu - View commit details
-
Copy full SHA for 90eaee2 - Browse repository at this point
Copy the full SHA 90eaee2View commit details
Commits on Oct 15, 2024
-
Update package with CVEs (#4881)
Update dependency System.IO.Packaging due to CVE-2024-43484, CVE-2024-43483 ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/4881)
Configuration menu - View commit details
-
Copy full SHA for 4e394fe - Browse repository at this point
Copy the full SHA 4e394feView commit details -
Add ADMX policies for security features in App Installer (#4726)
Configuration menu - View commit details
-
Copy full SHA for 1b25158 - Browse repository at this point
Copy the full SHA 1b25158View commit details
Commits on Oct 16, 2024
-
Consume all input during extract sequence (#4882)
## Change When extracting a sequence, consume all (up to 1KB really) input even if it doesn't start with an escape character. This was spurred by an issue where the `peek` call was not returning (waiting for input). Pressing Enter broke it out of that wait, but other input was now at the front and blocked future attempts to extract the sequence. The best solution to this would be to move all input handling to its own dedicated thread, but that is a much larger change.
Configuration menu - View commit details
-
Copy full SHA for fa62b8b - Browse repository at this point
Copy the full SHA fa62b8bView commit details -
Change meaning of AddOrUpdate return bool (#4885)
## Issue The requestor of this new (1.10) API needs to know whether the operation was an add or an update. At the same time, the "was the index modified" return value from Update has always been true for any changes since the manifest hash was added. ## Change Return `true` when adding and `false` when updating.
Configuration menu - View commit details
-
Copy full SHA for 9bfeedb - Browse repository at this point
Copy the full SHA 9bfeedbView commit details
Commits on Oct 21, 2024
-
Fix for Source Argument Validation in SourceWorkflow for Default Sour…
…ce Type (#4891) Fix for Source Argument Validation in SourceWorkflow for Default Source Type [Issues:] The current validation in the source flow correctly detects duplicate source names. However, when the source argument is validated along with the source type, it allows different source names with the same arguments for the empty source type. This happens because, during source type comparison, if the source type is not provided, it defaults to an empty string, which is compared against the default type (Microsoft.PreIndexed). This allows multiple different source names with the same argument to be considered valid sources. For an empty source type, the default source type is assigned during the source add operation, not beforehand. Consequently, after the source add operation is finished, the source will have some source arguments, but only the name will differ. [Fix:] For an empty source type, we should compare against the default source to prevent different source names with the same arguments for the default types. During validation, we obtain the default type to replace the empty source type and use it for comparison to validate argument duplication. - Extended source tests to validate the duplicate source argument scenario for the default source type. - Fixed additional failing source origin tests with appropriate fixes. [How Validated:] - Compiled the latest modifications and deployed the AppInstallerCLIPackage. - Executed CLI SourceTests to ensure all tests pass without issues. **[Manual validation:]** **Before fix:** ![image](https://github.com/user-attachments/assets/591b3ec2-ae6c-42ac-8258-169596657c4a) **After fix:** ![image](https://github.com/user-attachments/assets/2078b72a-d746-440c-a44e-2ec05c812e26) <!-- To check a checkbox place an "x" between the brackets. e.g: [x] --> - [x] I have signed the [Contributor License Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs). - [ ] This pull request is related to an issue. ----- ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/4891)
Configuration menu - View commit details
-
Copy full SHA for be13187 - Browse repository at this point
Copy the full SHA be13187View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cf604a - Browse repository at this point
Copy the full SHA 6cf604aView commit details
Commits on Oct 23, 2024
-
Bring back WinGetUtil nuspec for dev development (#4884)
Bringing back the nuspec used for creating the Microsoft.WindowsPackageManager.Utils nuget package. Fix CreateLocalNuget.ps1 ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/4884)
Configuration menu - View commit details
-
Copy full SHA for 9160218 - Browse repository at this point
Copy the full SHA 9160218View commit details
Commits on Oct 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fe939b8 - Browse repository at this point
Copy the full SHA fe939b8View commit details
Commits on Oct 28, 2024
-
WinGet Source COM API Support ### This update includes the following changes: 1. Implementation of WinGet COM Package Catalog Management APIs: - PackageManager.AddPackageCatalogAsync: Allows adding a new Package Catalog repository to the Windows Package Manager access list. Administrative rights are required to execute this API.. - PackageManager.RemovePackageCatalogAsync: Enables the removal of an existing Package Catalog from the Windows Package Manager access list. Administrative rights are required to execute this API. - By default, the 'PreserveData' field is set to false, removing both the PackageCatalog registration data and system artifacts. - When 'PreserveData' is set to true, only the PackageCatalog registration data is removed, while system artifacts remain. - PackageCatalogReference.RefreshPackageCatalogAsync: Allows updating an existing Package Catalog repository. 2. Necessary C# WinRT Projection to invoke the above API calls from the test classes. 3. PackageCatalogInterop E2E Inproc and OutOfproc Test Cases to validate: - AddPackageCatalogAsync - RemovePackageCatalogAsync - RefreshPackageCatalogAsync 4. Added a CallbackDispatcherSink struct that handles and dispatches progress callbacks for the scenario described above, ensuring progress is reported to the caller. 5. Updated Package.appxmanifest and Microsoft.Management.Deployment.InProc.dll.manifest to include the necessary COM RuntimeClass CLSIDs related to the aforementioned APIs ### How Validated: 1. Compiled AppInstaller.sln 2. Deployed AppInstallerCLIPackage 3. Copied Microsoft.Management.Deployment.winmd next to dot.exe process that runs test cases 4. Executed InProc tests locally and verified all tests pass. ![image](https://github.com/user-attachments/assets/1c677b85-6610-4b52-bf34-d784ba86d9db) related: #4170 - [x] I have signed the [Contributor License Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs). - [x] This pull request is related to an issue. ----- ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/4813)
Configuration menu - View commit details
-
Copy full SHA for f926640 - Browse repository at this point
Copy the full SHA f926640View commit details -
Configuration menu - View commit details
-
Copy full SHA for d60517e - Browse repository at this point
Copy the full SHA d60517eView commit details
Commits on Oct 30, 2024
-
Fix Microsoft Store's App Installer URL (#4925)
<!-- To check a checkbox place an "x" between the brackets. e.g: [x] --> - [x] I have signed the [Contributor License Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs). - [x] This pull request is related to an issue. - Closes #4924 The previous URL seems to be returning 503. cc @denelon ----- ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/4925)
Configuration menu - View commit details
-
Copy full SHA for b8f4133 - Browse repository at this point
Copy the full SHA b8f4133View commit details
Commits on Oct 31, 2024
-
Fix Repair-WinGetPackageManager cmdlet by retrieving dependencies fro…
…m GitHub assets (#4923)
Configuration menu - View commit details
-
Copy full SHA for cdd4b08 - Browse repository at this point
Copy the full SHA cdd4b08View commit details -
Remove attribute in DSC (#4932)
## Change Removes the attribute `ValidateNotNullOrWhiteSpace` as it is only available starting in 7.4. The attributes also only validate when the value is assigned, so enforcing that a value is set is more complete. ## Validation Loads in PS 7.2.8 now.
Configuration menu - View commit details
-
Copy full SHA for 03587c2 - Browse repository at this point
Copy the full SHA 03587c2View commit details
Commits on Nov 4, 2024
-
Add msstore productId to export manifest and to wingetutil interop ma…
…nifest object (#4934) This change was needed as part of the effort to make exported manifest (from winget download msstore apps) to be re-parsed and uploaded to winget rest source. Updated the some of the manifest schemas to add "required" for some required fields previously missing. Also, during my cross validation with the manifest schemas, I found ExpectedReturnCode::Custom was added in manifest but not actually updated in code. So I updated the ExpectedReturnCode map in code with this change too.
Configuration menu - View commit details
-
Copy full SHA for 02454cc - Browse repository at this point
Copy the full SHA 02454ccView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.9.25180...v1.10.30-preview