Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Support for Versions with Preambles #4558

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Improve Support for Versions with Preambles #4558

merged 5 commits into from
Jun 20, 2024

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Jun 14, 2024 •
edited by microsoft-github-policy-service bot
Loading

Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly requested a review from a team as a code owner June 14, 2024 23:43
@Trenly Trenly changed the title Preambles Improve Support for Versions with Preambles Jun 14, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
JohnMcPMS
JohnMcPMS reviewed Jun 18, 2024
View reviewed changes
src/AppInstallerCLITests/Versions.cpp Outdated Show resolved Hide resolved
src/AppInstallerSharedLib/Public/AppInstallerStrings.h Outdated Show resolved Hide resolved
src/AppInstallerSharedLib/Versions.cpp Outdated Show resolved Hide resolved
src/AppInstallerSharedLib/Versions.cpp Outdated Show resolved Hide resolved
@JohnMcPMS
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Trenly
Copy link
Contributor Author

Trenly commented Jun 18, 2024

Interesting . . . Looks like the HasExtension function for ManifestVersion uses a Version to store just the extensions, which is quite confusing

@JohnMcPMS
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JohnMcPMS JohnMcPMS merged commit 38aac87 into microsoft:master Jun 20, 2024
8 checks passed
@Trenly Trenly deleted the Preambles branch June 20, 2024 16:40
@Trenly Trenly mentioned this pull request Jun 26, 2024
Closed
@stephengillie stephengillie mentioned this pull request Oct 14, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnMcPMS JohnMcPMS JohnMcPMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Trenly @JohnMcPMS