-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to the PowerShell modules #4716
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
FYI I could not build this small part locally at all getting this error no matter what I do to try and build it
I also was thinking that on push to this repo that a build would be automatically triggered, though looking at other pr's it's manually being kicked off using the Other than that this is ready to merge if a build completes no issue |
/azp run |
Commenter does not have sufficient privileges for PR 4716 in repo microsoft/winget-cli |
was worth a shot 🤷🏻♂️ |
Just working on adding the additional bits needed for #4680 to get this all added in a single PR |
2df4144
to
3637914
Compare
src/PowerShell/Microsoft.WinGet.Client.Cmdlets/Cmdlets/GetSettingCmdlet.cs
Show resolved
Hide resolved
src/PowerShell/Microsoft.WinGet.Client.Cmdlets/Cmdlets/GetUserSettingCmdlet.cs
Show resolved
Hide resolved
src/PowerShell/Microsoft.WinGet.Client.Cmdlets/Cmdlets/GetSettingCmdlet.cs
Outdated
Show resolved
Hide resolved
src/PowerShell/Microsoft.WinGet.Client/ModuleFiles/Microsoft.WinGet.Client.psd1
Outdated
Show resolved
Hide resolved
@JohnMcPMS thanks for the comments, I'll get back to these during this week (hopefully tonight) as I have some updates on another device that was in progress at the end of the week. |
@kilasuit thanks for jumping in here! I think we'd want to make sure and update the appropriate "Help" files with the changes as well. Assuming this is all "non-breaking" changes, that can be a separate PR. I know we're also adding a new cmdlet for the WinGet Repair command. |
So this should be good for merging now & thanks for the ping @denelon - Tests and docs updated to the singular use Only other thoughts
|
If the cmdlets have been renamed to singular, I'd say we should keep them plural unless the help files get included in the PR. Probably best to do the rename in a separate PR so the help files don't break or confuse users. Get-Help and Get-Command should stay in sync. I'll let one of our engineers make the call on the remaining "other thoughts". |
Thought it best to add all in together so I have updated the helpfiles in this PR - though I can easily remove those commits if desired |
OK, we're cutting a build with the current cmdlets and help. As soon as that is out, we can dig back through this PR to get updates for all the changes. I really appreciate the help here! |
Looking good to me; we need to fix some infrastructure issues and then we can run the build/test pass. |
src/PowerShell/Microsoft.WinGet.Client.Cmdlets/Cmdlets/RepairWinGetPackageManagerCmdlet.cs
Outdated
Show resolved
Hide resolved
The following PR was just merged: Those examples should be included here. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I just rebased from the master branch & resolved the last comment so all good to go :-) |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
src/PowerShell/Microsoft.WinGet.Client.Cmdlets/Cmdlets/GetSettingCmdlet.cs
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Build was successful with my changes. @kilasuit, please sign off on the PR to indicate that you are done with changes and ready to merge. |
Yeah all good with me @JohnMcPMS |
- fixes Add aliases to the cmdlets in Microsoft.Winget.Client PowerShell module #4411
- fixes Make Microsoft.WinGet.Client PowerShell cmdlets "singular" in name #4680
Microsoft Reviewers: Open in CodeFlow
edit by @denelon - formatting for checkboxes :)