Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostics to dynamic factory #4757

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Aug 27, 2024

Change

Adds diagnostics to the dynamic factory.

Validation

Manually confirmed that diagnostics now flow out of dynamic factory.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS changed the title Add diagnostics to dynamic factory and fix tests Add diagnostics to dynamic factory Aug 27, 2024
@JohnMcPMS JohnMcPMS marked this pull request as ready for review August 27, 2024 20:47
@JohnMcPMS JohnMcPMS requested a review from a team as a code owner August 27, 2024 20:47
@JohnMcPMS
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@yao-msft yao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JohnMcPMS JohnMcPMS merged commit 8996d9b into microsoft:master Sep 3, 2024
9 checks passed
@JohnMcPMS JohnMcPMS deleted the text-fix branch September 3, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants