Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding __init__.py to avoid module not found errors #128

Merged
merged 5 commits into from
Mar 29, 2023

Conversation

chris-alexiuk-1
Copy link
Contributor

When pip installing, I was running into some module not found errors. This should resolve those.

Sorry if I missed a reason they weren't included.

@jpgard
Copy link
Collaborator

jpgard commented Mar 29, 2023

This shouldn't be necessary. As of Python 3.3, Python does not require init.py for the package to be importable. Are you using the conda environment we provide via environment.yml?

@chris-alexiuk-1
Copy link
Contributor Author

The error was occurring specifically when pip installing the PyPi package.

@anas-awadalla
Copy link
Collaborator

@chris-alexiuk I am able to reproduce the issue. Thanks for letting us know! I am testing your branch and will merge.

@anas-awadalla anas-awadalla merged commit 68d51df into mlfoundations:main Mar 29, 2023
@jpgard
Copy link
Collaborator

jpgard commented Mar 29, 2023

thank you for the PR @chris-alexiuk ! sorry for my confusion.

@chris-alexiuk-1
Copy link
Contributor Author

Absolutely no worries! Thanks for double-checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants