Skip to content

PYTHON-4489 Make setup.py private #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Conversation

blink1073
Copy link
Member

No description provided.

Verified

This commit was signed with the committer’s verified signature.
blink1073 Steven Silvester
@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot requested a review from Jibola June 10, 2024 15:16
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about adding a setup.py that prints a message and exits with an error to help out users? Something like "PyMongo>=4.9 no longer supports building via setup.py, use python -m pip install path/to/pymongo instead."

............................

- Since we are now using ``hatch`` as our build backend, we no longer have a ``setup.py`` file
and require installation using ``pip``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in 4.9 not 4.8, unless we are planning to backport PYTHON-4451.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be 4.8, PR is already open: #1663

Verified

This commit was signed with the committer’s verified signature.
blink1073 Steven Silvester
@blink1073
Copy link
Member Author

What do you think about adding a setup.py that prints a message and exits with an error to help out users?

Done

@blink1073 blink1073 requested a review from ShaneHarvey June 10, 2024 17:36
@blink1073 blink1073 merged commit f7faff8 into mongodb:master Jun 10, 2024
31 of 34 checks passed
@blink1073 blink1073 deleted the private-setup-py branch June 10, 2024 18:26
blink1073 added a commit that referenced this pull request Jun 10, 2024

Verified

This commit was signed with the committer’s verified signature.
blink1073 Steven Silvester
(cherry picked from commit f7faff8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants