Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Catch when stats channel is closed #1944

Merged
merged 1 commit into from
Jun 10, 2016

Conversation

gjtempleton
Copy link
Contributor

@gjtempleton gjtempleton commented Jun 7, 2016

  • Discovered during use that removal of a container the plugin has been attached to causes a panic due to attempting to close the statsrd channel when already closed by the go-dockerclient. This fix means it no longer attempts to do this and ensures it returns from the gofunc when it is closed.

I should have caught this sooner and only found it when using it in anger. Pretty sure this is the best way to solve the issue but any feedback is appreciated as usual.

@relistan
Copy link
Contributor

👍

@rafrombrc rafrombrc merged commit 705f469 into mozilla-services:dev Jun 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants