Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS_AddRemoveMid_Payload_t erroneously contains a CommandHeader #116

Closed
dmknutsen opened this issue Sep 13, 2023 · 1 comment · Fixed by #118
Closed

DS_AddRemoveMid_Payload_t erroneously contains a CommandHeader #116

dmknutsen opened this issue Sep 13, 2023 · 1 comment · Fixed by #118
Assignees

Comments

@dmknutsen
Copy link
Contributor

Checklist (Please check before submitting)

  • [x ] I reviewed the Contributing Guide.
  • [x ] I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
There appears to be a copy and paste error in ds_msg.h. DS_AddRemoveMid_Payload_t erroneously contains a command header feild.

Expected behavior
Payloads should not contain headers.

Reporter Info
Dan Knutsen
NASA Goddard

@skliper
Copy link
Contributor

skliper commented Sep 15, 2023

DS/fsw/inc/ds_msg.h

Lines 408 to 413 in 2a6c6a2

typedef struct
{
CFE_MSG_CommandHeader_t CommandHeader; /**< \brief cFE Software Bus command message header */
CFE_SB_MsgId_t MessageID; /**< \brief Message ID to add to Packet Filter Table */
} DS_AddRemoveMid_Payload_t;

havencarlson added a commit to havencarlson/DS that referenced this issue Sep 20, 2023
dzbaker added a commit that referenced this issue Sep 21, 2023
Fix #116, Removed command header from payload struct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants