Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #95, Replaces conditionally compiled code with runtime conditional logic #124

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

chillfig
Copy link
Contributor

@chillfig chillfig commented Feb 15, 2024

Checklist (Please check before submitting)

Describe the contribution

Testing performed

  • local build and lcov

Expected behavior changes
The changes intend on making the code easier to understand and maintain. The code coverage now reaches 100% when DS_MOVE_FILES or DS_FILE_HEADER_TYPE are toggled to/from their non-default state.

System(s) tested on

  • OS: Ubuntu 20.04

Additional context
N/A

Third party code
N/A

Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, Vantage Systems

*/
#define DS_MOVE_FILES true
#define DS_MOVE_FILES "Move to downlink directory"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would recommend changing this macro name. DS_MOVE_FILES should be gone entirely, and a new one line DS_MOVEFILES_DESTDIR exists instead

@chillfig chillfig force-pushed the cond_comp_code branch 2 times, most recently from 519e321 to e9124f2 Compare February 29, 2024 18:38
@chillfig chillfig force-pushed the cond_comp_code branch 6 times, most recently from 12935ba to 9e925a3 Compare March 26, 2024 13:01
@dzbaker dzbaker merged commit ec96b02 into nasa:main Mar 28, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove conditionally compiled code
3 participants