-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration #135
Labels
Support
User Support
Comments
msuder
changed the title
Transition nos3 Repository to be an Integration Only Repository Full of Submodules (and a few Integration Files)
Transition nos3 Repository to be an Integration Only Repository Full of Submodules (and a few Integration Files)?
Feb 14, 2023
msuder
changed the title
Transition nos3 Repository to be an Integration Only Repository Full of Submodules (and a few Integration Files)?
Configuration Discussion - Transition nos3 Repository to be an Integration Only Repository Full of Submodules (and a few Integration Files)?
Mar 24, 2023
jlucas9
changed the title
Configuration Discussion - Transition nos3 Repository to be an Integration Only Repository Full of Submodules (and a few Integration Files)?
Configuration Discussion
Mar 24, 2023
This was the document I created a few years ago when I was thinking about what should be submodules, what should be top level, what a build could look like, etc. |
jlucas9
added a commit
that referenced
this issue
Jan 3, 2024
jlucas9
added a commit
that referenced
this issue
Jan 18, 2024
[#135] Initial configuration framework
Merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Transition nos3 Repository to be an Integration Only Repository Full of Submodules (and a few Integration Files)?
Integration includes submodules for:
What else should be in the nos3 repo?
Pull request quote: "For now, this is ok. We need to have a larger, architectural discussion on separating/combining configuration information in the nos3, cosmos, and individual component repositories and figure out an evolutionary improvement strategy. (Code "smell" hint... avoid ../... out of the current git repository if at all possible.)"
config/system/nos3-system.txt is one example that drove this issue:
nasa-itc/gsw-cosmos#6
https://github.com/nasa-itc/gsw-cosmos/pull/6/files/f0f0e12f3f7ab589ca91e70c579a589b6772d088#diff-ff0853b0a827937d3e41ddbc65bbd9190cb001f012b0da914d8e5a65394b70c0
Every single file change (not submodule) changed by this: #130
PR provides a place to think about whether the "information"** that "fuses" the submodules together to become NOS3 could be managed and generated in a better way (perhaps by introspection into the submodules, using CMake effectively for building, and using other tools to combine run time configuration information?).
The simulator XML configuration is especially egregious as it is the one type of this "information" where the submodules in the "components" directory do not have their own copy of their own information in sims/cfg (other component development pull requests will also reveal the need for viewing 42 SC_*.txt and Inp_IPC.txt files as containing overarching NOS3 configuration information and component submodule configuration information that ideally should be split out and automagically combined also).
** information: examples include build time (e.g. fsw/nos3_defs/targets.cmake and runtime (all the other modified files such as FSW .scr start script, scheduler and TO tables, launch scripts, and simulator XML configuration)
The text was updated successfully, but these errors were encountered: