Adds NOT and XOR triggers for conditions #2816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds unit tests Fixes linting issues
charlesh88
approved these changes
Mar 27, 2020
akhenry
approved these changes
Mar 30, 2020
| let trueCount = 0; | ||
| for (let key in resultMap) { | ||
| if (resultMap.hasOwnProperty(key)) { | ||
| if (resultMap[key]) { |
There was a problem hiding this comment.
I think that generally speaking just checking for "truthiness" is a bit vague and can lead to subtle bugs. I'd prefer to be explicit here and check if (resultMap[key]) === true or if (resultMap[key]) !== undefined - whatever the intended behavior is here.
| 'any': 'when any criteria are met', | ||
| 'all': 'when all criteria are met', | ||
| 'not': 'when no criteria are met', | ||
| 'xor': 'when only one criteria is met' |
There was a problem hiding this comment.
Being pedantic, but it should be criterion singular (as we correctly have it elsewhere in our code).
Reviewer Checklist
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2811
Author Checklist